Fix pre-commit failure with noqa: ANN401 #691
Conversation
https://docs.astral.sh/ruff/rules/any-type Also, why not make this change? ```diff def is_empty(val: Any) -> bool: - return val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) + return not val ```
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a pre-commit linting failure by adding a noqa: ANN401 comment to suppress ruff's warning about using Any type annotation. The change addresses a specific linting rule that flags the use of Any type hints as potentially problematic.
Key Changes
- Added
noqa: ANN401comment to suppress ruff's any-type warning for theis_emptyfunction parameter
| @@ -368,7 +368,7 @@ def wipe_component_info(self) -> None: | |||
| }, | |||
| } | |||
|
|
|||
| def is_empty(val: Any) -> bool: | |||
| def is_empty(val: Any) -> bool: # noqa: ANN401 | |||
| return val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) | |||
There was a problem hiding this comment.
Consider replacing the complex logic with return not val as suggested in the PR description. The current implementation val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) is redundant since Python's truthiness evaluation already handles these cases correctly, and the dict check is unnecessary as empty dicts are falsy.
| return val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) | |
| return not val |
Copilot uses AI. Check for mistakes.
|
Thanks for looking into this. I've merged a better, simpler fix just now. |
https://docs.astral.sh/ruff/rules/any-type --> https://results.pre-commit.ci/repo/github/778163871
Also, why not make this change?